Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): Only follow rear tip sensor during calibration setup #14984

Merged
merged 10 commits into from
Apr 23, 2024
Merged

feat(app): Only follow rear tip sensor during calibration setup #14984

merged 10 commits into from
Apr 23, 2024

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Apr 23, 2024 •
edited
Loading

Overview

Accompanies #14980.

Changelog

  • changes ht_operational_sensor name to ht_follow_singular_sensor
  • use primary sensor in calibration and lpc probe attach flow

@caila-marashaj caila-marashaj requested review from a team as code owners April 23, 2024 16:28
@caila-marashaj caila-marashaj requested review from smb2268 and removed request for a team April 23, 2024 16:28
@caila-marashaj caila-marashaj force-pushed the calibration-only-follow-rear-tip-sensor branch from 09f5b9e to e3f5cb4 Compare April 23, 2024 16:35
@caila-marashaj caila-marashaj requested a review from a team as a code owner April 23, 2024 17:04
vegano1
vegano1 reviewed Apr 23, 2024
View reviewed changes
app/src/organisms/LabwarePositionCheck/AttachProbe.tsx Outdated
@@ -96,7 +96,7 @@ export const AttachProbe = (props: AttachProbeProps): JSX.Element | null => {
const verifyCommands: CreateCommand[] = [
{
commandType: 'verifyTipPresence',
params: { pipetteId: pipetteId, expectedState: 'present' },
params: { pipetteId: pipetteId, expectedState: 'present', FollowSingularSensor: 'primary' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should rename this with camel case to keep front-end format

followSingularSensor

mjhuff
mjhuff reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE looks good with Brayan's comment!

smb2268
smb2268 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js changes look good!

@caila-marashaj caila-marashaj merged commit 446da56 into edge Apr 23, 2024
53 checks passed
@caila-marashaj caila-marashaj deleted the calibration-only-follow-rear-tip-sensor branch April 23, 2024 19:00
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@caila-marashaj @Carlos-fernandez
feat(app): Only follow rear tip sensor during calibration setup (#14984)
060a647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff left review comments

@vegano1 vegano1 vegano1 left review comments

@ahiuchingau ahiuchingau ahiuchingau approved these changes

@smb2268 smb2268 smb2268 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caila-marashaj @vegano1 @smb2268 @ahiuchingau @mjhuff